Skip to content

Revert "Add an option to return early from an allocate call (#134786)" #135476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Revert "Add an option to return early from an allocate call (#134786)" #135476

merged 1 commit into from
Sep 25, 2025

Conversation

@DiannaHohensee
Copy link
Contributor

@DiannaHohensee DiannaHohensee commented Sep 25, 2025

This reverts commit 43741c2.

@DiannaHohensee DiannaHohensee self-assigned this Sep 25, 2025
@DiannaHohensee DiannaHohensee added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team labels Sep 25, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 25, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

JeremyDahlgren
JeremyDahlgren approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@JeremyDahlgren JeremyDahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiannaHohensee DiannaHohensee added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 25, 2025
@elasticsearchmachine elasticsearchmachine merged commit 31f1810 into elastic:main Sep 25, 2025
34 checks passed
@DiannaHohensee DiannaHohensee deleted the 2025/09/25/revert-early-return branch September 25, 2025 21:00
This was referenced Sep 26, 2025
Closed
Closed
Closed
Closed
Closed
Closed
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Sep 29, 2025
@ywangd
Reapply "Add an option to return early from an allocate call (elastic…
1ba1a5c 
…#134786)" (elastic#135476)

This reverts commit 31f1810.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeremyDahlgren JeremyDahlgren JeremyDahlgren approved these changes

Assignees

@DiannaHohensee DiannaHohensee

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DiannaHohensee @elasticsearchmachine @JeremyDahlgren