Improved validation and added option to include incubator modules for API Extractor tool #135529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
ldematte
approved these changes
Sep 26, 2025
|
so far it's simple enough and I don't see a need yet, but I agree that would be a good next step in case we ever want multi valued args instead of pure flags. I considered making the list of modules configurable, but in the end didn't see a need for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few improvements to the api-extractor tool.
I've also investigated the value of observing changes in the localedata module. But I don't think there's much use to do this with this approach. The significant changes we're interested in are hidden in the CLDR xml files. Extracting useful information of changes there would be independent and has to be developed from scratch.
Relates to ES-11757