Allow reindex.remote.whitelist to be set to *
#135546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, ES would refuse to start if the `reindex.remote.whitelist` node setting was `*` (or anything else which matches every string). This removes that restriction. The logic did not provide any real security, since it would accept a setting value of `*:*`, which would effectively match everything since the string checked against it was always of the form `<host>:<port>`. It has been agreed that users should be allowed to whitelist everything if they choose, so there is no value to just making it more awkward for them to figure out how to do so.
PeteGillinElastic
added
>non-issue
:Data Management/Indices APIs
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
changed the title
reindex.remote.whitelist to be set to *reindex.remote.whitelist to be set to *
PeteGillinElastic
deleted the
allow-universal-reindex-remote-whitelist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, ES would refuse to start if the
reindex.remote.whitelistnode setting was*(or anything else which matches every string). This removes that restriction.The logic did not provide any real security, since it would accept a setting value of
*:*, which would effectively match everything since the string checked against it was always of the form<host>:<port>. It has been agreed that users should be allowed to whitelist everything if they choose, so there is no value to just making it more awkward for them to figure out how to do so.