record security exceptions in resolved index expressions #135630
+160
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-dennehy
added
>non-issue
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
reviewed
Oct 7, 2025
| if (e instanceof IndexNotFoundException) { | ||
| listener.onFailure(e); | ||
| } else { | ||
| listener.onFailure(actionDenied(authentication, authzInfo, action, request, e)); |
There was a problem hiding this comment.
We need to set security exceptions in the case where the action actually succeeded (due to ignore_unavailable=true) instead of when it failed. When it failed, the recorded expressions are irrelevant since we will throw directly. So we need to take the request post resolution and see if:
- it has resolved expressions recorded
- if any of those have
CONCRETE_RESOURCE_UNAUTHORIZEDset
If the above is true, we need to set an actionDenied exception as you do below
|
Sorry, only got to this late! @richard-dennehy could you update the branch, address this bit, and the req a review from @ywangd when it's ready? If my comment doesn't make sense I hope Yang can provide guidance. The Jira, for reference is ES-13005. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record security exception for resolved index expressions with
CONCRETE_RESOURCE_UNAUTHORIZEDresults