Skip to content

Fix over-aggressive usage of EMPTY in ExtendedSearchUsageStats #135649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Fix over-aggressive usage of EMPTY in ExtendedSearchUsageStats #135649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87695ee
Fix test failure
kderusso Sep 29, 2025
cd4412b
Merge branch 'main' into kderusso/fix-search-usage-stat-test
kderusso Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,9 +591,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/134407
- class: org.elasticsearch.action.admin.cluster.stats.SearchUsageStatsTests
method: testToXContent
issue: https://github.com/elastic/elasticsearch/issues/135558
- class: org.elasticsearch.search.ccs.SparseVectorQueryBuilderCrossClusterSearchIT
method: testSparseVectorQueryWithCcsMinimizeRoundTripsFalse
issue: https://github.com/elastic/elasticsearch/issues/135559
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/action/admin/cluster/stats/SearchUsageStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public SearchUsageStats() {
this.sections = new HashMap<>();
this.rescorers = new HashMap<>();
this.retrievers = new HashMap<>();
this.extendedSearchUsageStats = ExtendedSearchUsageStats.EMPTY;
this.extendedSearchUsageStats = new ExtendedSearchUsageStats();
}

/**
Expand Down