-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add Sampling Configuration Actions #135651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces action classes for managing sampling configuration in Elasticsearch, specifically adding PutSamplingConfigurationAction and associated functionality for configuring sampling settings on indices.
- Adds PutSamplingConfigurationAction class with request/response handling for sampling configuration
- Implements comprehensive test coverage for the new action including serialization, mutation testing, and validation
- Provides API for configuring sampling parameters like rate, max samples, size limits, TTL, and conditions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
PutSamplingConfigurationAction.java | Main action class implementing sampling configuration functionality with request handling, serialization, and task creation |
PutSamplingConfigurationActionTests.java | Comprehensive test suite covering serialization, mutation testing, and action validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ava/org/elasticsearch/action/admin/indices/sampling/PutSamplingConfigurationActionTests.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/action/admin/indices/sampling/PutSamplingConfigurationAction.java
Outdated
Show resolved
Hide resolved
# Conflicts: # server/src/test/java/org/elasticsearch/action/admin/indices/sampling/PutSamplingConfigurationActionTests.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ain/java/org/elasticsearch/action/admin/indices/sampling/PutSamplingConfigurationAction.java
Show resolved
Hide resolved
…mpling/PutSamplingConfigurationAction.java Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR adds the action classes associated with setting, getting, and deleting Sampling Configurations.
Set Configuration
The set configuration API structure will be similar to the following:
Get Configuration
The GET //_sample/config API will get a specific configuration. For example:
An API to get all currently-configured APIs will also be provided:
Delete Configuration
A delete API, DELETE //_sample/config, will remove the sampling configuration for the given index or data stream and cleans up any associated in-memory storage.