[Transform] Reset health status on successful noop #135653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve elastic#135650
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @prwhelan, I've created a changelog YAML for you. |
jonathan-buttner
approved these changes
Sep 29, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Sep 29, 2025
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve elastic#135650
This was referenced Sep 29, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Sep 29, 2025
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve elastic#135650
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Sep 29, 2025
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve elastic#135650
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Sep 29, 2025
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve elastic#135650
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve #135650
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
…135657) * [Transform] Reset health status on successful noop (#135653) When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve #135650 * use old API for removing read blocks
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
…135655) * [Transform] Reset health status on successful noop (#135653) When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count. This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index. Resolve #135650 * use old API for removing read blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no results for the current checkpoint, the checkpoint is considered successful, and the transform will reset its failure count.
This fixes a bug where transform will continue to report unhealthy if it previously failed to search the source index.
Resolve #135650
Ran new tests with iters=1000 and they passed