Add shard search subphase metrics for the fetch subphases. #135713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
chrisparrinello
commented
Sep 30, 2025
| boolean requiresSource = storedFieldsSpec.requiresSource(); | ||
| final int[] locallyAccumulatedBytes = new int[1]; | ||
| NestedDocuments nestedDocuments = context.getSearchExecutionContext().getNestedDocuments(); | ||
| final Map<String, Long> subphaseAggregateDurations = new HashMap<>(); |
There was a problem hiding this comment.
Part of the complicating factor here is that we call the subphase processors on individual hits, so we need to aggregate across all of the hits for this shard. Please let me know if I'm not understanding this code properly.
chrisparrinello
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Hi @chrisparrinello, I've created a changelog YAML for you. |
|
Cancelling to rethink whether this is actually necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new APM metrics for the fetch subphases. Metrics have names with the format of
es.search.shards.phases.fetch.subphase.<subphase_name>.duration.histogram.