Clamp family of functions #135822

pabloem · 2025-10-02T03:36:54Z

TODO

Add ClampMaxTests
Add ClampMinTests
Add Clamp max examples
Add clamp min examples

github-actions · 2025-10-02T03:38:33Z

🔍 Preview links for changed docs

github-actions · 2025-10-02T03:38:33Z

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Check out the cumulative docs guidelines
Reach out in the #docs Slack channel

elasticsearchmachine · 2025-10-03T16:36:45Z

Pinging @elastic/es-storage-engine (Team:StorageEngine)

dnhatn

I've left some comments. Thank you, Pablo! I will do another detailed review.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/adsads

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/asdasd

x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries-clamp.csv-spec

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMax.java

...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/Clamp.java

dnhatn

It's getting closer. Thanks Pablo!

dnhatn · 2025-10-08T05:43:09Z

docs/reference/query-languages/esql/_snippets/functions/description/clamp_max.md

+
+**Description**
+
+Returns clamps the values of all input samples clamped to have an upper limit of max.


nit: remove returns

docs/reference/query-languages/esql/_snippets/functions/description/clamp_min.md

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMin.java

...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/Clamp.java

x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries-clamp.csv-spec

pabloem · 2025-10-08T18:06:04Z

looks like we do need some serialization functions: https://buildkite.com/elastic/elasticsearch-pull-request/builds/97622#0199c4c2-84d0-4364-9f05-0e4764c8d79d/98-3431

dnhatn · 2025-10-08T19:09:38Z

You can disable it here for the ClampTests:

elasticsearch/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/AbstractFunctionTestCase.java

Line 503 in d0d4339

protected boolean canSerialize() {

pabloem · 2025-10-08T20:13:45Z

that's embarrassing. thanks nhat - working on that...

dnhatn

I left some minor comments; the comments for ClampMax also applies to ClampMin. The PR looks great; please address these before merging. Thanks, Pablo!

dnhatn · 2025-10-09T04:10:57Z

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMax.java

+
+    @Override
+    public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
+        // force datatype initialization


leftover comment?

dnhatn · 2025-10-09T04:12:53Z

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMax.java

+        }
+
+        var field = children().get(0);
+        var min = children().get(1);


dnhatn · 2025-10-09T04:17:01Z

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMax.java

+        }
+        resolution = TypeResolutions.isType(
+            min,
+            t -> t.isNumeric() ? fieldDataType.isNumeric() : t.noText() == fieldDataType,


t.noText() == fieldDataType.noText()

dnhatn · 2025-10-09T04:18:09Z

.../main/java/org/elasticsearch/xpack/esql/expression/function/scalar/conditional/ClampMax.java

+        var outputType = dataType();
+
+        var max = children().get(1);
+        var maxF = outputType != max.dataType()


Maybe check the element type of both side to avoid the cast? PlannerUtils.toElementType(outputType) != PlannerUtils.toElementType(max.dataType())?

dnhatn · 2025-10-09T04:19:05Z

x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries-clamp.csv-spec

+12.125                   | 2024-05-10T00:07:19.000Z
+12.125                   | 2024-05-10T00:17:39.000Z
+12.0                     | 2024-05-10T00:08:08.000Z
+;


another ask - can you ask a test where min/max is another column instead of constant?

kkrik-es · 2025-10-09T06:36:01Z

Let's make sure Nhat's comments are addressed, in a follow-up. It's a good idea to skip auto-submit.

pabloem · 2025-10-09T15:17:40Z

yes I will address on a follow-up!

dnhatn · 2025-10-09T16:54:57Z

No worries, thanks Pablo! They're just minor comments.

pabloem added 2 commits September 30, 2025 17:08

clamp test suite for csv

d48b17b

Working con clamp family of functions

7b9b449

elasticsearchmachine added v9.3.0 needs:triage Requires assignment of a team area label labels Oct 2, 2025

pabloem changed the title ~~Clamp family of functions~~ [wip] Clamp family of functions Oct 2, 2025

john-wagster added the :StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL label Oct 3, 2025

elasticsearchmachine added Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Oct 3, 2025

pabloem and others added 2 commits October 3, 2025 11:35

Finalized Clamp function

fb80136

Merge branch 'main' into pem-clamp-function

b8af4a3

pabloem added the >feature label Oct 3, 2025

fixup

32c6735

pabloem changed the title ~~[wip] Clamp family of functions~~ Clamp family of functions Oct 3, 2025

pabloem requested review from dnhatn and kkrik-es October 3, 2025 23:24

dnhatn reviewed Oct 7, 2025

View reviewed changes

pabloem and others added 4 commits October 7, 2025 15:28

comments

b0a4348

fix the tests

14c1214

Merge branch 'main' into pem-clamp-function

3fb2509

fixup

36e8b0a

dnhatn self-requested a review October 8, 2025 05:42

dnhatn reviewed Oct 8, 2025

View reviewed changes

dnhatn self-requested a review October 8, 2025 05:55

pabloem and others added 2 commits October 8, 2025 09:38

fixup - comments

10d640d

Merge branch 'main' into pem-clamp-function

d82b288

fxup

5df1d1c

elasticsearchmachine and others added 2 commits October 8, 2025 18:17

[CI] Auto commit changes from spotless

6052808

fixup writable

e78023b

pabloem and others added 4 commits October 8, 2025 13:16

fixup

18ae4ef

[CI] Auto commit changes from spotless

f8460f2

fixup

1be59d7

Merge branch 'main' into pem-clamp-function

3b48105

pabloem enabled auto-merge (squash) October 9, 2025 02:43

dnhatn added >enhancement and removed >feature labels Oct 9, 2025

dnhatn approved these changes Oct 9, 2025

View reviewed changes

pabloem merged commit 80a3488 into elastic:main Oct 9, 2025
34 checks passed


		Description

		Returns clamps the values of all input samples clamped to have an upper limit of max.

Clamp family of functions #135822

Clamp family of functions #135822

Uh oh!

Conversation

pabloem commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

github-actions bot commented Oct 2, 2025

ℹ️ Important: Docs version tagging

When to use applies_to tags:

What NOT to do:

🤔 Need help?

Uh oh!

elasticsearchmachine commented Oct 3, 2025

Uh oh!

dnhatn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnhatn left a comment

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

pabloem Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pabloem commented Oct 8, 2025

Uh oh!

dnhatn commented Oct 8, 2025

Uh oh!

pabloem commented Oct 8, 2025

Uh oh!

dnhatn left a comment

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dnhatn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kkrik-es commented Oct 9, 2025

Uh oh!

pabloem commented Oct 9, 2025

Uh oh!

dnhatn commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

pabloem commented Oct 2, 2025 •

edited

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading