Fix ESQL index resolution #135826
Draft
Fix ESQL index resolution #135826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
Team:Analytics
This was referenced Oct 2, 2025
idegtiarenko
commented
Oct 2, 2025
|
|
||
| public void testInexistentIndexNameWithWildcard() throws IOException { | ||
| assertErrorMessages(inexistentIndexNameWithWildcard, getInexistentIndexErrorMessage(), 400); | ||
| } |
There was a problem hiding this comment.
Now wildcards are allowed to expand to empty result set
idegtiarenko
commented
Oct 2, 2025
| assertThat(e.getMessage(), containsString("verification_exception")); | ||
| assertThat(e.getMessage(), anyOf(containsString("Unknown index [foo]"), containsString("Unknown index [remote_cluster:foo]"))); | ||
|
|
||
| e = expectThrows(ResponseException.class, () -> runEsql(timestampFilter("gte", "2020-01-01").query(from("foo*")))); |
There was a problem hiding this comment.
The same, foo* can now expand to empty result set
idegtiarenko
commented
Oct 2, 2025
| String q = "FROM cluster-a:nomatch*"; | ||
| String expectedError = "Unknown index [cluster-a:nomatch*]"; | ||
| expectVerificationExceptionForQuery(q, expectedError, requestIncludeMeta); | ||
| expectVerificationExceptionForQuery(q, expectedError, requestIncludeMeta);// TODO this must contain the remote cluster alias |
There was a problem hiding this comment.
Here we are getting RemoteTransportException with cause IndexNotFoundException with index nonmatch. It is correct, but it does not give me enough information to point out to cluster-a in case there are multiple remotes involved. This is likely needs to be added on FieldCaps side
# Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RequestIndexFilteringTestCase.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/IndexResolver.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates various aspects of ES|QL index resolution including:
Fixes: #114495
Fixes: #127347