Fix ESQL index resolution #135826
Fix ESQL index resolution #135826
Conversation
idegtiarenko
added
Team:Analytics
|
|
||
| public void testInexistentIndexNameWithWildcard() throws IOException { | ||
| assertErrorMessages(inexistentIndexNameWithWildcard, getInexistentIndexErrorMessage(), 400); | ||
| } |
There was a problem hiding this comment.
Now wildcards are allowed to expand to empty result set
| assertThat(e.getMessage(), containsString("verification_exception")); | ||
| assertThat(e.getMessage(), anyOf(containsString("Unknown index [foo]"), containsString("Unknown index [remote_cluster:foo]"))); | ||
|
|
||
| e = expectThrows(ResponseException.class, () -> runEsql(timestampFilter("gte", "2020-01-01").query(from("foo*")))); |
There was a problem hiding this comment.
The same, foo* can now expand to empty result set
| String q = "FROM cluster-a:nomatch*"; | ||
| String expectedError = "Unknown index [cluster-a:nomatch*]"; | ||
| expectVerificationExceptionForQuery(q, expectedError, requestIncludeMeta); | ||
| expectVerificationExceptionForQuery(q, expectedError, requestIncludeMeta);// TODO this must contain the remote cluster alias |
There was a problem hiding this comment.
Here we are getting RemoteTransportException with cause IndexNotFoundException with index nonmatch. It is correct, but it does not give me enough information to point out to cluster-a in case there are multiple remotes involved. This is likely needs to be added on FieldCaps side
# Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RequestIndexFilteringTestCase.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/IndexResolver.java
| listener.onResponse(new FieldCapabilitiesResponse(Collections.emptyList(), Collections.emptyList())); | ||
| } | ||
| } | ||
| listener.onResponse(new FieldCapabilitiesResponse(new ArrayList<>(indexResponses.values()), failures)); |
There was a problem hiding this comment.
This is our "fork" of Field caps action.
This change actually never completes the listener exceptionally. Instead it always completes it with FieldCapabilitiesResponse containing both responses and failures. This way we could accumulate and report all unresolved indices in esql IndexResolver.
I wonder if we should port this behavior to original Field Caps (likely hidden by returnAllFailures flag or something?
@piergm may be you have an opinion on this. Also cc @nik9000 as he originally forked this part.
2 participants
This change updates various aspects of ES|QL index resolution including:
Fixes: #114495
Fixes: #127347