Skip to content

[ML] Remove rate limit field from services API for EIS #135838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2025
+5 −25
Merged

[ML] Remove rate limit field from services API for EIS #135838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d82df5
Remove rate limit field from services API for EIS
davidkyle Oct 2, 2025
8cc177b
Update docs/changelog/135838.yaml
davidkyle Oct 2, 2025
e0e3232
Merge branch 'main' into eis-no-rate-limit
davidkyle Oct 3, 2025
85d445f
Merge branch 'main' into eis-no-rate-limit
davidkyle Oct 8, 2025
1f540e4
Merge branch 'main' into eis-no-rate-limit
davidkyle Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/135838.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 135838
summary: Remove rate limit field from services API for EIS
area: Machine Learning
type: bug
issues: []
7 changes: 0 additions & 7 deletions ...main/java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
import org.elasticsearch.xpack.inference.services.elastic.rerank.ElasticInferenceServiceRerankServiceSettings;
import org.elasticsearch.xpack.inference.services.elastic.sparseembeddings.ElasticInferenceServiceSparseEmbeddingsModel;
import org.elasticsearch.xpack.inference.services.elastic.sparseembeddings.ElasticInferenceServiceSparseEmbeddingsServiceSettings;
import org.elasticsearch.xpack.inference.services.settings.RateLimitSettings;
import org.elasticsearch.xpack.inference.telemetry.TraceContext;

import java.util.EnumSet;
Expand Down Expand Up @@ -683,12 +682,6 @@ public static InferenceServiceConfiguration createConfiguration(EnumSet<TaskType
.build()
);

configurationMap.putAll(
RateLimitSettings.toSettingsConfiguration(
EnumSet.of(TaskType.SPARSE_EMBEDDING, TaskType.CHAT_COMPLETION, TaskType.RERANK, TaskType.TEXT_EMBEDDING)
)
);

return new InferenceServiceConfiguration.Builder().setService(NAME)
.setName(SERVICE_NAME)
.setTaskTypes(enabledTaskTypes)
Expand Down
18 changes: 0 additions & 18 deletions ...java/org/elasticsearch/xpack/inference/services/elastic/ElasticInferenceServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,15 +971,6 @@ public void testCreateConfiguration() throws Exception {
"name": "Elastic",
"task_types": ["sparse_embedding", "chat_completion", "text_embedding"],
"configurations": {
"rate_limit.requests_per_minute": {
"description": "Minimize the number of rate limit errors.",
"label": "Rate Limit",
"required": false,
"sensitive": false,
"updatable": false,
"type": "int",
"supported_task_types": ["text_embedding", "sparse_embedding" , "rerank", "chat_completion"]
},
"model_id": {
"description": "The name of the model to use for the inference task.",
"label": "Model ID",
Expand Down Expand Up @@ -1028,15 +1019,6 @@ public void testGetConfiguration_WithoutSupportedTaskTypes() throws Exception {
"name": "Elastic",
"task_types": [],
"configurations": {
"rate_limit.requests_per_minute": {
"description": "Minimize the number of rate limit errors.",
"label": "Rate Limit",
"required": false,
"sensitive": false,
"updatable": false,
"type": "int",
"supported_task_types": ["text_embedding", "sparse_embedding" , "rerank", "chat_completion"]
},
"model_id": {
"description": "The name of the model to use for the inference task.",
"label": "Model ID",
Expand Down