Skip to content

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Oct 2, 2025

Defer failures on semantic_text fields created in pre-8.11 indices to when the first document is ingested. This is accomplished by reverting #133080 and moving the index version check to when the document is parsed.

@Mikep86 Mikep86 requested a review from kderusso October 2, 2025 13:17
@Mikep86 Mikep86 added >bug auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.2.0 v8.19.5 v9.1.5 v8.18.8 v9.0.8 labels Oct 2, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search - Relevance The Search organization Search Relevance team v9.3.0 labels Oct 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @Mikep86, I've created a changelog YAML for you.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for fixing

@Mikep86 Mikep86 merged commit 66d9241 into elastic:main Oct 2, 2025
34 checks passed
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 135845

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Oct 2, 2025

💔 Some backports could not be created

Status Branch Result
9.1
9.0 Conflict resolution was aborted by the user
8.19
8.18

Manual backport

To create the backport manually run:

backport --pr 135845

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Oct 2, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…5869)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…35871)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

* Fix compile errors

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…5872)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* Update comment

* [CI] Auto commit changes from spotless

* Fix compile errors

---------

Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…35870)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v8.18.8 v8.19.5 v9.0.8 v9.1.5 v9.2.0 v9.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants