Skip spec tests when test cluster broken #135862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
v9.2.0
v8.19.1
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
nik9000
approved these changes
Oct 3, 2025
|
Previously you have to look at the first failure. But after this you'll look at the only failure. It'll just be that everything else is skipped. This'll kick in if the cluster crashes or if it unassignes a bunch of shards, likely because a node crashes. All things that can happen in testing. |
|
Thanks friends! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Oct 4, 2025
If the test clusters are broken, we should stop running spec tests; otherwise we will see a lot of failures, making triage and investigating more difficult.
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test clusters are broken, we should stop running spec tests; otherwise we will see a lot of failures, making triage and investigating more difficult.