Skip to content

Conversation

@chrisparrinello
Copy link
Contributor

New metrics created:

  • es.search.coordinator.phases.can_match.duration.histogram
  • es.search.coordinator.phases.dfs.duration.histogram
  • es.search.coordinator.phases.dfs_query.duration.histogram
  • es.search.coordinator.phases.expand.duration.histogram
  • es.search.coordinator.phases.fetch.duration.histogram
  • es.search.coordinator.phases.fetch_lookup_fields.duration.histogram
  • es.search.coordinator.phases.rank_feature.duration.histogram

@chrisparrinello chrisparrinello requested a review from a team as a code owner October 2, 2025 18:39
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Oct 2, 2025
@chrisparrinello chrisparrinello added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations >enhancement and removed needs:triage Requires assignment of a team area label labels Oct 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @chrisparrinello, I've created a changelog YAML for you.

@chrisparrinello chrisparrinello force-pushed the coordinator_phase_metrics branch from 5aefeac to cecc641 Compare October 2, 2025 19:03
@javanna
Copy link
Member

javanna commented Oct 3, 2025

Hey @chrisparrinello , would it make sense to start with one latency measured on the coord node, and next expand to others in following PRs?

Take for instance DFS, or query, or fetch, to start with. We only measure these so far on the shards, but we'd like to see the overall latency for these on the coord nodel so that it is comparable to the took time.

@chrisparrinello
Copy link
Contributor Author

@javanna Yeah I think I might need to take that approach with this as well based on the CI results which I've run into issues around opening the point-in-time around "reflecting" the metric name from the phase. A more straightforward targeted metric collection is doable but the downside I think is that metric object might need to be passed around a little more to get it down to the SearchPhase implementations. I'll take a stab at the query phase first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants