Skip to content

Adds Internal mechanisms and retriever for MMR based result diversification #135880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Adds Internal mechanisms and retriever for MMR based result diversification #135880

wants to merge 23 commits into from

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Oct 2, 2025 •
edited
Loading

This PR adds the internal implementation for result diversification via MMR. This is the baseline and will be able to be utilized by mechanisms in the expand search phase to provide result diversification.

@markjhoy markjhoy requested review from a team and ioanatia October 3, 2025 22:05
@markjhoy markjhoy marked this pull request as ready for review October 3, 2025 22:05
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 3, 2025
@markjhoy markjhoy added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >feature labels Oct 3, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Oct 3, 2025
@markjhoy markjhoy added >enhancement Team:Search - Relevance The Search organization Search Relevance team and removed >feature labels Oct 3, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search - Relevance The Search organization Search Relevance team label Oct 3, 2025
@markjhoy
Copy link
Contributor Author

markjhoy commented Oct 7, 2025 •
edited
Loading

Note - the VectorDocs in the context should be gathered in the forCollapsing method of the QueryPhaseCollectorManager

@ioanatia
Copy link
Contributor

ioanatia commented Oct 7, 2025

I think it would be good if we can get a PR/branch that show how these will be integrated - and then we can merge break the changes into smaller PRs if needed.

@markjhoy markjhoy marked this pull request as draft October 8, 2025 17:04
@markjhoy markjhoy marked this pull request as ready for review October 16, 2025 17:48
@markjhoy markjhoy requested review from a team and ioanatia and removed request for a team and ioanatia October 16, 2025 17:49
@markjhoy markjhoy changed the title Adds Internal mechanisms for MMR based result diversification Adds Internal mechanisms and retriever for MMR based result diversification Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioanatia ioanatia Awaiting requested review from ioanatia

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

>enhancement needs:triage Requires assignment of a team area label v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markjhoy @ioanatia @elasticsearchmachine