Create a version of bbq_hnsw that supports on_disk_rescore #135931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thecoop, I've created a changelog YAML for you. |
|
HNSW format is not generic because I didn't want to make the formats completely generic - I still wanted top-level named formats in this version. A generic flat format still gives us lots of flexibility, and I think we should explore how far this gets us before introducing extra complexity of multiple generic layers. |
thecoop
force-pushed
the
bbq_hnsw-disk-rescoring
branch
from
8545008 to
84e5fc3
Compare
thecoop
force-pushed
the
bbq_hnsw-disk-rescoring
branch
from
84e5fc3 to
207475c
Compare
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
thecoop
changed the title
thecoop
commented
Oct 8, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/GenericFlatVectorReaders.java
Show resolved
Hide resolved
thecoop
changed the title
benwtrent
reviewed
Oct 8, 2025
...r/src/main/java/org/elasticsearch/index/codec/vectors/es93/ES93GenericFlatVectorsReader.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/vectors/GenericFlatVectorReaders.java
Show resolved
Hide resolved
...va/org/elasticsearch/index/codec/vectors/es93/ES93HnswBinaryQuantizedVectorsFormatTests.java
Show resolved
Hide resolved
benwtrent
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a version of bbq_hnsw that supports direct IO rescoring, via a generic quantized flat vectors layer.
The HNSW layer is not generic (yet), it still uses a top-level hard-coded
ES93Hnswformat, but the raw format used by the quantization layer is generic.