Fixing ChunkingSettingsBuilder test for generating rerank chunking settings #135965
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>test
prwhelan
approved these changes
Oct 6, 2025
dan-rubinstein
added
auto-backport
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test randomly generates a query word count that is used to build chunking settings for reranked chunking. There are two different behaviors depending on whether the query word count generated is less than half of the elastic reranker model's token limit or greater than/equal to half the limit. This test was aiming to generate a random query word count less than half the model's limit but since
randomIntBetweenis inclusive on both ends, it was able to generate a query word count that was exactly half the limit. This change fixes this by making sure the upper limit on the random number is 1 less than half the limit and removes the mute on the test.