Forbidding dimension fields in aggregated stats - only allowed in grouping attributes #135981
+99
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uping attributes - fixes elastic#135335
pabloem
added
>feature
:StorageEngine/TSDB
elasticsearchmachine
added
needs:triage
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
reviewed
Oct 4, 2025
...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/TimeSeriesAggregate.java
Outdated
Show resolved
Hide resolved
...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/TimeSeriesAggregate.java
Show resolved
Hide resolved
dnhatn
added
>non-issue
v9.2.1
auto-backport
dnhatn
reviewed
Oct 6, 2025
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Outdated
Show resolved
Hide resolved
limotova
reviewed
Oct 7, 2025
| required_capability: absent_over_time | ||
| required_capability: k8s_dataset_additional_fields | ||
| TS k8s | STATS is_present = max(absent_over_time(pod)) BY cluster, time_bucket = tbucket(10minute) | SORT time_bucket, cluster | LIMIT 10; | ||
| TS k8s | STATS is_present = max(absent_over_time(network.eth0.tx)) BY cluster, time_bucket = tbucket(10minute) | SORT time_bucket, cluster | LIMIT 10; |
There was a problem hiding this comment.
In the interest of type-coverage can we maybe add a keyword field to the dataset for these functions? From the mappings event should be a keyword, but I guess it was never actually generated...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uping attributes - fixes #135335