Skip to content

Conversation

@mjmbischoff
Copy link
Contributor

@mjmbischoff mjmbischoff commented Oct 4, 2025

Updated logic to avoid autoboxing by adding hasValue methods for type-specific blocks.

Item on the road to GA of MV_CONTAINS, see discussion in #133636 and #133099. Other item is #135723

@elasticsearchmachine elasticsearchmachine added v9.3.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 4, 2025
@mjmbischoff mjmbischoff added >non-issue auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL labels Oct 4, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Oct 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@mjmbischoff mjmbischoff requested a review from ivancea October 4, 2025 14:24
@mjmbischoff mjmbischoff self-assigned this Oct 4, 2025
@mjmbischoff
Copy link
Contributor Author

@ivancea what's the blessed way to address the mixed-cluster tests failing?

@ivancea
Copy link
Contributor

ivancea commented Oct 6, 2025

@mjmbischoff I see the error is the change of empty string behaviour. We'll need to make a new capability for it , to avoid running those tests against versions with the old behaviour. (Or rename the existing cap to something like *_V2, which should do the same "reusing" the old capability)
After changing the capability in the test, it should not fail.

final var count = getValueCount(valueIndex);
final var startIndex = getFirstValueIndex(valueIndex);
$if(BytesRef)$
var ref = new BytesRef();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pass the scratch in for this in BytesRefBlock. One scratch per position feels like a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, long day. Renamed it to position.

I've moved the scratch up one level though in the back of my mind I do wonder if we'll have a net gain from this as we might just break escape analysis 'a stack too far' so to speak.

@mjmbischoff mjmbischoff merged commit ff40585 into elastic:main Oct 6, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 135991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants