Skip to content

[ML] Cohere service Model Id field is required #136017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −2
Open

[ML] Cohere service Model Id field is required #136017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7959ae
Model Id is required
davidkyle Oct 6, 2025
b43eebe
Update docs/changelog/136017.yaml
davidkyle Oct 6, 2025
bbf9870
Merge branch 'main' into cohere-model-required
davidkyle Oct 6, 2025
854b3e1
Merge branch 'main' into cohere-model-required
davidkyle Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/136017.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 136017
summary: Cohere service Model Id field is required
area: Machine Learning
type: bug
issues: []
2 changes: 1 addition & 1 deletion ...erence/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ public static InferenceServiceConfiguration get() {
"The name of the model to use for the inference task."
)
.setLabel("Model ID")
.setRequired(false)
.setRequired(true)
.setSensitive(false)
.setUpdatable(false)
.setType(SettingsConfigurationFieldType.STRING)
Expand Down
2 changes: 1 addition & 1 deletion ...e/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,7 +1556,7 @@ public void testGetConfiguration() throws Exception {
"model_id": {
"description": "The name of the model to use for the inference task.",
"label": "Model ID",
"required": false,
"required": true,
"sensitive": false,
"updatable": false,
"type": "str",
Expand Down