Split SplitShardCountSummary into index and search types #136047
Closed
+172
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mostly motivated by the fact that they depend on different TransportVersions for serialization, but it also seems like it might be good to protect against using a search summary as an index summary when making staleness decisions, and vice versa.
bcully
added
>non-issue
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
|
converted to draft - it includes a transport version for search summaries but doesn't actually include them in the request path so that transport version check would be wrong. |
|
This doesn't handle serialization in a sane way - it's up to an individual request path to serialize/deserialize this field so the field itself can't know the transport version requirements. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly motivated by the fact that they depend on different TransportVersions for serialization, but it also seems like it might be good to protect against using a search summary as an index summary when making staleness decisions, and vice versa.