ESQL Fix bug when renaming @timestamp in TS queries #136062
Open
+390
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>bug
:StorageEngine/ES|QL
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @not-napoleon, I've created a changelog YAML for you. |
not-napoleon
commented
Oct 6, 2025
| } | ||
| if (attr.name().equals(MetadataAttribute.TIMESTAMP_FIELD)) { | ||
| timestamp.set(attr); | ||
| } |
There was a problem hiding this comment.
I consider it a happy bonus of this PR that we are no longer fishing out the timestamp as part of the translate rule. I wonder if we should do something similar for the TSID. It just seems wrong to be doing this here.
not-napoleon
commented
Oct 6, 2025
| * @param typeToken Only process expressions matching the given type | ||
| * @param rule a non-modifying consumer which operates on the given token type | ||
| * @param <E> the type of expression this pass will process | ||
| */ |
There was a problem hiding this comment.
I had to ask @fang-xing-esql how this worked, so I've written down what I learned from that conversation.
not-napoleon
commented
Oct 6, 2025
There was a problem hiding this comment.
I didn't add a randomized timestamp to the serialization tests because I expect that it won't be serialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #134994
This PR addresses the issue with queries like
Here, the
rateaggregation function has an implied argument of@timestamp, but that field no longer exists when we get to the to the stats command. To solve this, we introduce a new specialization to theResolveRefsrule that finds the timestamp alias and plumbs it into theTimeSeriesAggregation. In addition to fixing the references for the implied arguments, it also sends the reference on as part of theTimeSeriesAggregationfor other use in theTranslateTimeSeriesAggregaterule.