-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[ES\QL] Add a section for vector functions in the doc. #136077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES\QL] Add a section for vector functions in the doc. #136077
Conversation
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Pinging @elastic/core-docs (Team:Docs) |
docs/reference/query-languages/esql/_snippets/lists/vector-functions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides knn, the other functions are not out of snapshot yet - let's remove them, or add them commented out similar to raw.githubusercontent.com/elastic/elasticsearch/0363570e9df2eac6c40a89b418c340acc2450258/docs/reference/query-languages/esql/functions-operators/search-functions.md
We shouldn't include the knn docs twice, because this would be bad for SEO, as we'd have duplicate pages in the docs. We should pick one page (vector functions), include it there, and link there from the other. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple minor comments/suggestions
docs/reference/query-languages/esql/functions-operators/vector-functions.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/functions-operators/search-functions.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/lists/dense-vector-functions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this @afoucret !
…d when we will be uncommenting them
@afoucret in --- appliesTo = { @FunctionAppliesTo(lifeCycle = FunctionAppliesToLifecycle.PREVIEW)
+++ appliesTo = { @FunctionAppliesTo(lifeCycle = FunctionAppliesToLifecycle.PREVIEW, version = "9.2.0") |
docs/reference/query-languages/esql/_snippets/lists/dense-vector-functions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for iterating so fast, I couldn't keep up 😁
There are no section for vector functions in the reference doc.
Added one.