Skip to content

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Oct 7, 2025

There are no section for vector functions in the reference doc.

Added one.

@afoucret afoucret added >docs General docs changes :Search Relevance/ES|QL Search functionality in ES|QL v9.3.0 labels Oct 7, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Oct 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides knn, the other functions are not out of snapshot yet - let's remove them, or add them commented out similar to raw.githubusercontent.com/elastic/elasticsearch/0363570e9df2eac6c40a89b418c340acc2450258/docs/reference/query-languages/esql/functions-operators/search-functions.md

@afoucret afoucret requested a review from carlosdelest October 7, 2025 14:18
@leemthompo
Copy link
Contributor

leemthompo commented Oct 7, 2025

We shouldn't include the knn docs twice, because this would be bad for SEO, as we'd have duplicate pages in the docs. We should pick one page (vector functions), include it there, and link there from the other.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Copy link
Contributor

github-actions bot commented Oct 7, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor comments/suggestions

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this @afoucret !

@leemthompo
Copy link
Contributor

@afoucret in Knn.java, the applies_to needs to be updated with version. On line 106::

--- appliesTo = { @FunctionAppliesTo(lifeCycle = FunctionAppliesToLifecycle.PREVIEW)
+++ appliesTo = { @FunctionAppliesTo(lifeCycle = FunctionAppliesToLifecycle.PREVIEW, version = "9.2.0")

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for iterating so fast, I couldn't keep up 😁

@afoucret afoucret enabled auto-merge (squash) October 7, 2025 15:46
@afoucret afoucret self-assigned this Oct 7, 2025
@afoucret afoucret merged commit 8028218 into elastic:main Oct 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/ES|QL Search functionality in ES|QL Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants