Delay automaton creation in BinaryDvConfirmedQuery to avoid OOM on queries against WildCard fields #136086
+166
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @iverase, I've created a changelog YAML for you. |
benwtrent
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
This helps us in an extreme edge case for sure. I wonder how much we will gain here though.
Do you know why we don't eagerly check BoolQueryBuilder as well before building the inner queries at all? It seems like we should be checking in our builders directly even before we construct the Lucene queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed some OOM exceptions on queries containing boolean queries with many nested wildcard BinaryDvConfirmedQueries. What is annoying on these situations is that those queries will likely hit the max boolean clauses and never succeed but because we are eagerly creating the automatons when creating the queries, we are exhausting the heap available.
In order to avoid that, this change proposes to delay the creation of the automatons when we create the Weight of the query, giving a change to the max boolean clause to stop the execution of abusive queries.