Skip to content

Conversation

dimitris-athanasiou
Copy link
Contributor

Previously the inference_id of semantic_text fields was not updatable. This commit allows users to update the inference_id of a semantic_text field. This is particularly useful for scenarios where the user wants to switch to using the same model but from a different service.

There are two circumstances when the update is allowed.

  • No values have been written for the semantic_text field.

The inference endpoint can be changed freely as there is no need for compatibility between the current and the new endpoint.

  • The new inference endpoint is compatible with the previous one.

The model_settings of the new inference endpoint are compatible with those of the current endpoint, thus the update is allowed.

Previously the `inference_id` of `semantic_text` fields was not updatable.
This commit allows users to update the `inference_id` of a `semantic_text` field.
This is particularly useful for scenarios where the user wants to switch to using
the same model but from a different service.

There are two circumstances when the update is allowed.

  - No values have been written for the `semantic_text` field.

The inference endpoint can be changed freely as there is no need for
compatibility between the current and the new endpoint.

  - The new inference endpoint is compatible with the previous one.

The `model_settings` of the new inference endpoint are compatible
with those of the current endpoint, thus the update is allowed.
@dimitris-athanasiou dimitris-athanasiou added >enhancement :SearchOrg/Relevance Label for the Search (solution/org) Relevance team :Search Foundations/Search Catch all for Search Foundations v9.3.0 labels Oct 7, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch Team:Search - Relevance The Search organization Search Relevance team labels Oct 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @dimitris-athanasiou, I've created a changelog YAML for you.

@dimitris-athanasiou
Copy link
Contributor Author

PR is ready for review. However, I intend to add documentation changes soon.

@@ -0,0 +1,5 @@
pr: 136120
summary: Allow updating `inference_id` of `semantic_text` fields
area: "Search"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search or Mapping?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say mapping

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🔍 Preview links for changed docs

Copy link
Contributor

github-actions bot commented Oct 8, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor wording suggestions from me :)

to create the endpoint. If `search_inference_id` is specified, the {{infer}}
endpoint will only be used at index time.

::::{applies-switch}
Copy link
Contributor

@leemthompo leemthompo Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to say that I think you can indent this whole applies-switch section a little bit, otherwise LGTM :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to be able to do this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries :)

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've left a few comments but I think it's pretty close.

@@ -0,0 +1,5 @@
pr: 136120
summary: Allow updating `inference_id` of `semantic_text` fields
area: "Search"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say mapping

* @param modelSettings the new model settings. If null the mapper will be returned unchanged.
* @return A mapper with the copied settings applied
*/
private SemanticTextFieldMapper copyWithNewModelSettingsIfNotSet(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're doing a null check here before we copy the settings, but we silently ignore if that case happens. Should we throw if it's not null and this method is called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be that it's not null because the update itself contains model_settings. In that case the explicitly set model_settings take precedence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review this file, assume it's the same as the other yaml test

Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, didn't get to the tests. I'll pick it up next week.

Co-authored-by: Mike Pellegrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Search Foundations/Search Catch all for Search Foundations :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants