-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Optionally ignore field when indexed field name exceeds length limit #136143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally ignore field when indexed field name exceeds length limit #136143
Conversation
Hi @jordan-powers, I've created a changelog YAML for you. |
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
||
--- | ||
|
||
"Test field name length limit": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a test where the field will not be ignored? Or update these tests to add two fields, one field that would be ignored because field name length is exceeded and one field just under this limit?
); | ||
public static final Setting<Boolean> INDEX_MAPPING_IGNORE_DYNAMIC_BEYOND_FIELD_NAME_LENGTH_SETTING = Setting.boolSetting( | ||
"index.mapping.field_name_length.ignore_dynamic_beyond_limit", | ||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in a follow up change we can consider defaulting to true in case of logsdb and tsdb?
This PR adds an index setting
index.mapping.field_name_length.ignore_dynamic_beyond_limit
. When this setting is set, fields dynamically added to the mapping that would violate theindex.mapping.field_name_length.limit
are silently ignored instead of causing an exception and preventing indexing of the document.Fixes #135700