Skip to content

Fix and unmute tests in DataStreamIndexSettingsProviderTests #136162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

Fix and unmute tests in DataStreamIndexSettingsProviderTests #136162

merged 2 commits into from
Oct 8, 2025
+10 −18

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Oct 8, 2025 •
edited
Loading

Closes #135972 and #135884

(I've tested the whole DataStreamIndexSettingsProviderTests locally with 100 iterations)

@felixbarny felixbarny self-assigned this Oct 8, 2025
@felixbarny felixbarny added >test Issues or PRs that are addressing/adding tests v9.3.0 labels Oct 8, 2025
@felixbarny felixbarny enabled auto-merge (squash) October 8, 2025 07:59
@felixbarny felixbarny added the :StorageEngine/TSDB You know, for Metrics label Oct 8, 2025
@elasticsearchmachine elasticsearchmachine added Team:StorageEngine external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

This was referenced Oct 8, 2025
Closed
Closed
@nielsbauman
Copy link
Contributor

Small drive-by comment: GitHub doesn't understand the and in your PR description unfortunately. You have to write both issue numbers on separate lines with Closes.

@nielsbauman
Copy link
Contributor

And thanks for opening a fix so quickly :)

@felixbarny felixbarny linked an issue Oct 8, 2025 that may be closed by this pull request
[CI] DataStreamIndexSettingsProviderTests testGetAdditionalIndexSettingsMappingsMerging failing #135884
Closed
leontyevdv
leontyevdv approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@leontyevdv leontyevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixbarny felixbarny merged commit 88a6827 into elastic:main Oct 8, 2025
34 checks passed
@felixbarny felixbarny deleted the ds-index-setting-provider-test-fix branch October 8, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leontyevdv leontyevdv leontyevdv approved these changes

Assignees

@felixbarny felixbarny

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.3.0
Projects
None yet
Milestone
No milestone
4 participants
@felixbarny @elasticsearchmachine @nielsbauman @leontyevdv