Skip to content

Updates FailedToCommitClusterStateException javadoc #136204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+1 −0
Closed

Updates FailedToCommitClusterStateException javadoc #136204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e6d5b
Updates FailedToCommitClusterStateException javadoc
joshua-adams-1 Oct 8, 2025
dc73973
Updates comment
joshua-adams-1 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...main/java/org/elasticsearch/cluster/coordination/FailedToCommitClusterStateException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

/**
* Exception indicating a cluster state update was published and may or may not have been committed.
* This exception can only be thrown by the master node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The" master node suggests you mean the currently-elected master, but if an elected master node cannot commit a cluster state update then it already isn't really the elected master node any more (and the cluster may already have elected a different node as the master).

But then if we just say "a" master node then it doesn't really mean much: this fact is implied by the fact that it's a consequence of publishing a state update, which is only done by the elected master.

* <p>
* If this exception is thrown, then the cluster state update was published, but is not guaranteed
* to be committed, including the next master node. This exception should only be thrown when there is
Expand Down