Always fetch node usage stats for write load decider #136212
Merged
+36
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeUsageStats Action will not be unconditionally called every 30 seconds, regardless of the write load decider being enabled. It is a lightweight action that fetches stats that are collected on the node regardless. This supports better seeing what happens when the write load decider is enabled, providing a before- (not just after) enablement picture. ES-12631
DiannaHohensee
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
force-pushed
the
2025/10/08/ES-12631-enable-stats
branch
from
57d1d26 to
9948453
Compare
nicktindall
reviewed
Oct 9, 2025
| randomBoolean() | ||
| ? WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED | ||
| : WriteLoadConstraintSettings.WriteLoadDeciderStatus.LOW_THRESHOLD_ONLY | ||
| ); |
There was a problem hiding this comment.
Doesn't this change mean the above test is invalid (i.e. we should always fetch the node usage stats)?
There was a problem hiding this comment.
Ah the test is indeed broken. LGTM when this is fixed.
nicktindall
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeUsageStats* Action will now be unconditionally called
every 30 seconds, regardless of the write load decider being
enabled. It is a lightweight action that fetches stats that
are collected on the node regardless. This supports better
seeing what happens when the write load decider is enabled,
providing a before- (not just after) enablement picture.
ES-12631