Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #126609,
TransportSamlLogoutAction
andTransportSamlInvalidateSessionAction
have a gap in their implementation where execution occurring on the generic thread pool unintentionally forks to a transport_worker thread. This is related to usage ofclient::get
andclient::bulk
methods within the flow, whereclient
refers toNodeClient
that will always execute a given task on a transport worker thread. (seeNodeClient.executeLocally
and the discussion here.This change refactors the existing consumers and wraps them such that the follow up work after we have retrieved
GetResponse
/BulkResponse
is re-directed back to the generic thread pool, i.e. afterclient
has done its job retrieving these responses.