Skip to content

Conversation

jfreden
Copy link
Contributor

@jfreden jfreden commented Oct 9, 2025

This PR removes the dependency on the ES version in BWC testing for API Keys introduced in #134604

I missed this during review. ES version should not be used to determine if a test should run or not, instead node features should be used.

@jfreden jfreden added the test-full-bwc Trigger full BWC version matrix tests label Oct 9, 2025
@jfreden jfreden added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label labels Oct 9, 2025
@jfreden jfreden marked this pull request as ready for review October 9, 2025 12:56
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Oct 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@slobodanadamovic slobodanadamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
(pending green CI)

@jfreden jfreden added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 9, 2025
@jfreden
Copy link
Contributor Author

jfreden commented Oct 10, 2025

CI failures are known intermittent issues with FullClusterRestartIT #136353 that's a different test suite form my changes and this PR has had a full successful BWC run so I'll merge this.

@jfreden jfreden enabled auto-merge (squash) October 10, 2025 08:11
@jfreden jfreden disabled auto-merge October 10, 2025 09:50
@jfreden jfreden removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 10, 2025
@jfreden jfreden merged commit f5063cd into elastic:main Oct 10, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants