Skip to content

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Oct 9, 2025

No description provided.

@breskeby breskeby requested a review from a team as a code owner October 9, 2025 08:22
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v8.19.6 v9.1.6 v9.0.9 v8.18.9 v9.2.1 v9.3.0 labels Oct 9, 2025
@breskeby breskeby self-assigned this Oct 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@jozala jozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with the fixed address found to be fixed.
I'm also wondering if that's something serverless specific what maybe could be moved to the serverless repo. WDYT?

value 'Git Commit ID', esCommit
tag "pr/${esPr}"
tag 'pull-request'
link 'Source', "https://github.com/jfreden/elasticsearch/tree/${esCommit}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "source" link should dynamically point to the commit in the PR source repo.
However, I'm not sure we can get the PR source as BUILDKITE_PULL_REQUEST_REPO is empty in the es-pr-check builds I've checked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I changed it to just point to the commit in the context of the PR

@breskeby breskeby requested a review from jozala October 9, 2025 10:17
Copy link
Contributor

@jozala jozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby merged commit 40c76bc into elastic:main Oct 9, 2025
35 checks passed
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Oct 9, 2025
…#136257)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Oct 9, 2025
…#136257)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Oct 9, 2025
…#136257)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
9.1
9.0
8.18 Commit could not be cherrypicked due to conflicts
9.2

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 136257

elasticsearchmachine pushed a commit that referenced this pull request Oct 9, 2025
#136277)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
elasticsearchmachine pushed a commit that referenced this pull request Oct 9, 2025
#136276)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
@breskeby breskeby deleted the mark-es-pr-check-as-pr-scan branch October 9, 2025 12:46
elasticsearchmachine pushed a commit that referenced this pull request Oct 9, 2025
#136278)

These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the
context in the generated build scans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.18.9 v8.19.6 v9.0.9 v9.1.6 v9.2.1 v9.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants