-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[CI] Tag es-pr-check serverless build scans with original PR #136257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-delivery (Team:Delivery) |
jozala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with the fixed address found to be fixed.
I'm also wondering if that's something serverless specific what maybe could be moved to the serverless repo. WDYT?
| value 'Git Commit ID', esCommit | ||
| tag "pr/${esPr}" | ||
| tag 'pull-request' | ||
| link 'Source', "https://github.com/jfreden/elasticsearch/tree/${esCommit}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "source" link should dynamically point to the commit in the PR source repo.
However, I'm not sure we can get the PR source as BUILDKITE_PULL_REQUEST_REPO is empty in the es-pr-check builds I've checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. I changed it to just point to the commit in the context of the PR
jozala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#136257) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
…#136257) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
…#136257) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
💔 Backport failed
You can use sqren/backport to manually backport by running |
#136277) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
#136276) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
#136278) These are serverless builds that run in the context of an elasticsearch PR. Therfore we want to keep the context in the generated build scans.
No description provided.