- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25.6k
Fix inference fields handling on old indices #136312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inference fields handling on old indices #136312
Conversation
| Pinging @elastic/search-relevance (Team:Search - Relevance) | 
| Hi @Mikep86, I've created a changelog YAML for you. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment/question. LGTM otherwise
        
          
                server/src/main/java/org/elasticsearch/index/get/ShardGetService.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | Hi @Mikep86, I've updated the changelog YAML for you. | 
| @elasticmachine update branch | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 💚 Backport successful
 | 
Fixes cases where
_inference_fieldswas included in_sourcewhen it shouldn't have been on indices created prior to #131907. Moreover, If_sourcewas disabled in the request, it caused the query failure described in #136130.Randomized unit and integration tests have also been added to provide more robust test coverage and avoid regressions in this area.