[ML] Auditor reset fix #136363
Merged
[ML] Auditor reset fix #136363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
commented
Oct 10, 2025
| abstract class AbstractMlAuditor<T extends AbstractAuditMessage> extends AbstractAuditor<T> { | ||
|
|
||
| private static final Logger logger = LogManager.getLogger(AbstractMlAuditor.class); | ||
| private volatile boolean isResetMode; |
There was a problem hiding this comment.
The isResetMode logic does not appear to be necessary and is removed it to avoid sending 2 different messages (the first to enable reset mode and the second to disable it). CI may tell a different story.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 13, 2025
Adds auditor reset action for deterministic resets in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that assert certain messages are audited can fail because the test clean up can leak into the next test. When this happens the first few auditor messages of the current test are deleted by the reset request that has leaked from the previous test.
The fix is to add an explicit auditor reset action and call that rather than using the cluster state to communicate the reset request. This guarantees the auditor has been reset in the test clean up.
Closes #134001 #129457 #128166