-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Fix snapshot upgrade test #136433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DonalEvans
merged 2 commits into
elastic:main
from
DonalEvans:fix-snapshot-upgrade-with-mixed-cluster
Oct 13, 2025
Merged
Fix snapshot upgrade test #136433
DonalEvans
merged 2 commits into
elastic:main
from
DonalEvans:fix-snapshot-upgrade-with-mixed-cluster
Oct 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead Closes elastic#98560
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Oct 13, 2025
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead Closes elastic#98560 (cherry picked from commit 6257be7) # Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportUpgradeJobModelSnapshotAction.java
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Oct 13, 2025
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead Closes elastic#98560 (cherry picked from commit 6257be7) # Conflicts: # muted-tests.yml # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportUpgradeJobModelSnapshotAction.java
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Oct 13, 2025
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead Closes elastic#98560 (cherry picked from commit 6257be7) # Conflicts: # muted-tests.yml # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportUpgradeJobModelSnapshotAction.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
DonalEvans
added a commit
to DonalEvans/elasticsearch
that referenced
this pull request
Oct 13, 2025
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead Closes elastic#98560 (cherry picked from commit 6257be7) # Conflicts: # muted-tests.yml # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportUpgradeJobModelSnapshotAction.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using transport version to determine if a cluster is mixed version is sometimes unreliable, so use DiscoveryNodes versions instead
Closes #98560