Deny usage of metric attributes known to cause issues. #136478
+86
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to their mapping or cardinality, certain metric attributes are likely to cause issues. Such attribute names are denied by a new assertion Relates to ES-13074
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Oct 13, 2025
| ); | ||
|
|
||
| // forbidden attributes known to cause issues due to mapping conflicts or high cardinality | ||
| static final Predicate<String> FORBIDDEN_ATTRIBUTE_NAMES = Regex.simpleMatcher( |
There was a problem hiding this comment.
TBC this is just assuming the naming that a developer would use, but doesn't guarantee the same metric isn't used with a different name, right?
There was a problem hiding this comment.
there's two issues:
- some fields get mapped to timestamps (see ES-13074), we have to prevent usage of these to prevent such metrics from being silently dropped at ingestion. such errors don't surface anywhere unfortunately.
- high cardinality metrics, adding index here just as precaution for this not to happen again. i also tried to forbid *_id as it indicates some higher cardinality label but there's still two usages of it we have to fix first
There was a problem hiding this comment.
Wondering if we should change the interfaces to require metric names to be models as enums to prevent uncontrolled cardinality. Though, that's a massive change :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to their mapping or cardinality, certain metric attributes are likely to cause issues.
Such attribute names are denied by a new assertion
Relates to ES-13074