-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix cachability of transport validation tasks #136484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
breskeby
approved these changes
Oct 13, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
This was referenced Oct 13, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
rjernst
added a commit
that referenced
this pull request
Oct 13, 2025
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Core
Core issues without another label
>refactoring
Team:Core/Infra
Meta label for core/infra team
v8.19.6
v9.1.6
v9.2.0
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transport version validation tasks were meant to be cachable, but since they don't output a file they aren't actually cachable. This commit fixes these tasks by making them PrecommitTasks which output a marker file on success.