Skip to content

Fixing SamplingServiceTests.testClusterChanged() #136489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Fixing SamplingServiceTests.testClusterChanged() #136489

merged 1 commit into from
Oct 13, 2025
+3 −2

Conversation

masseyke
Copy link
Member

This makes two fixes to SamplingServiceTests.testClusterChanged():

  1. It prevents the test from running when the random sampling feature is not present
  2. It avoids an edge case where the index request is larger than the maximum size of the entire sample

Closes #136450

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v9.3.0 labels Oct 13, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

PeteGillinElastic
PeteGillinElastic approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@masseyke masseyke added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 13, 2025
@elasticsearchmachine elasticsearchmachine merged commit f0b850f into elastic:main Oct 13, 2025
34 checks passed
@masseyke masseyke deleted the fix-SamplingServiceTests-testClusterChanged branch October 13, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeteGillinElastic PeteGillinElastic PeteGillinElastic approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] SamplingServiceTests testClusterChanged failing

3 participants

@masseyke @elasticsearchmachine @PeteGillinElastic