Skip to content

[9.2] Fix cachability of transport validation tasks (#136484) #136505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

[9.2] Fix cachability of transport validation tasks (#136484) #136505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/org/elasticsearch/gradle/internal/transport/ValidateTransportVersionReferencesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

package org.elasticsearch.gradle.internal.transport;

import org.gradle.api.DefaultTask;
import org.elasticsearch.gradle.internal.conventions.precommit.PrecommitTask;
import org.gradle.api.file.RegularFileProperty;
import org.gradle.api.provider.Property;
import org.gradle.api.services.ServiceReference;
Expand All @@ -30,7 +30,7 @@
* Validates that each transport version reference has a referable definition.
*/
@CacheableTask
public abstract class ValidateTransportVersionReferencesTask extends DefaultTask implements VerificationTask {
public abstract class ValidateTransportVersionReferencesTask extends PrecommitTask implements VerificationTask {

@ServiceReference("transportVersionResources")
abstract Property<TransportVersionResourcesService> getTransportResources();
Expand Down
4 changes: 2 additions & 2 deletions ...va/org/elasticsearch/gradle/internal/transport/ValidateTransportVersionResourcesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

import com.google.common.collect.Comparators;

import org.elasticsearch.gradle.internal.conventions.precommit.PrecommitTask;
import org.elasticsearch.gradle.internal.transport.TransportVersionResourcesService.IdAndDefinition;
import org.gradle.api.DefaultTask;
import org.gradle.api.file.ConfigurableFileCollection;
import org.gradle.api.provider.Property;
import org.gradle.api.services.ServiceReference;
Expand Down Expand Up @@ -40,7 +40,7 @@
* Validates that each defined transport version constant is referenced by at least one project.
*/
@CacheableTask
public abstract class ValidateTransportVersionResourcesTask extends DefaultTask implements VerificationTask {
public abstract class ValidateTransportVersionResourcesTask extends PrecommitTask implements VerificationTask {

@InputDirectory
@Optional
Expand Down