Skip to content

ES|QL: Make ResolveUnionTypes rule stateless (#136492) #136527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
+8 −5
Merged

ES|QL: Make ResolveUnionTypes rule stateless (#136492) #136527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/136492.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 136492
summary: Make `ResolveUnionTypes` rule stateless
area: ES|QL
type: bug
issues: []
8 changes: 3 additions & 5 deletions x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,11 +1365,9 @@ private static class ResolveUnionTypes extends Rule<LogicalPlan, LogicalPlan> {

record TypeResolutionKey(String fieldName, DataType fieldType) {}

private List<FieldAttribute> unionFieldAttributes;

@Override
public LogicalPlan apply(LogicalPlan plan) {
unionFieldAttributes = new ArrayList<>();
List<FieldAttribute> unionFieldAttributes = new ArrayList<>();
// Collect field attributes from previous runs
plan.forEachUp(EsRelation.class, rel -> {
for (Attribute attr : rel.output()) {
Expand All @@ -1379,10 +1377,10 @@ public LogicalPlan apply(LogicalPlan plan) {
}
});

return plan.transformUp(LogicalPlan.class, p -> p.childrenResolved() == false ? p : doRule(p));
return plan.transformUp(LogicalPlan.class, p -> p.childrenResolved() == false ? p : doRule(p, unionFieldAttributes));
}

private LogicalPlan doRule(LogicalPlan plan) {
private LogicalPlan doRule(LogicalPlan plan, List<FieldAttribute> unionFieldAttributes) {
int alreadyAddedUnionFieldAttributes = unionFieldAttributes.size();
// See if the eval function has an unresolved MultiTypeEsField field
// Replace the entire convert function with a new FieldAttribute (containing type conversion knowledge)
Expand Down