[ES|QL] pushing down eval expression when it requires data access #136610
+353
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_function_error_no_shards
…thub.com:pmpailis/elasticsearch into fix_133462_fixing_score_function_error_no_shards
…re_function_error_no_shards
pmpailis
changed the title
pmpailis
added
>non-issue
:Search Relevance/ES|QL
|
Hi @pmpailis, I've created a changelog YAML for you. |
…thub.com:pmpailis/elasticsearch into fix_133462_fixing_score_function_error_no_shards
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that the
SCOREfunction will be executed on data nodes even when dealing with evalFUNCTION. To that end, in this PR we update thePushDownAndCombineLimitsrule so thatLIMITis not pushed further from anEVALexpression if:SCOREBy doing so, the
evalis pushed to the data node, where the check above does not hold, so that the limit is pushed and reaches the underlying LuceneOperator.Closes #133462.