-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix append processor ignore_empty_values edge case #136649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @joegallo, I've created a changelog YAML for you. |
masseyke
approved these changes
Oct 15, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 16, 2025
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
Team:Data Management
Meta label for data/management team
v9.2.0
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #105718
With
allow_duplicates: false, we're pretty careful to not upcast a scalar into a list unless some kind of change has been made to the value -- that is, if you have a value of"2"and you are ignoring duplicates and you try to append"2"onto it, you still have a value of"2"and not["2"].With #105718, there's a new behavioral path, that is
ignore_empty_values: true. We need to take the same care here that we don't upcast a scalar (or the absence of a value) into a list unless there's actually some value to be appended. That is, if you haveignore_empty_values: trueand all the values that you want to append are actually empty, then the resulting operation should be a no-op, but it wasn't! This PR fixes that.ALSO, I'm super pleased with how
innerAppendValuesandinnerAppendValuesWithDuplicatesdrop out because of this, I've never been especially happy with those methods existing. 😄Note: Given that there's another BC, I actually expect this to land in v9.2.0 (I imagine the labels will get corrected at some point).
Additional note: related to #104813, with was the feature request that asked for something like
ignore_empty_valuesto begin with.