Fix and unmute append processor tests #136687
Merged
+9
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
#136700 is up for the 9.2 backport, so I'm removing the |
|
joegallo
added a commit
that referenced
this pull request
Oct 16, 2025
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136657
Closes #136662
Closes #136667
I introduced these test failures with #136649, I should have been more suspicious that my changes were passing tests. These fail something like 5% of the time for some of the tests, and I didn't run with
-Dtests.iters=10000, so I missed them. Sloppy!Anyway, the problem is just the tests, not the change itself. 😅
There's another problem that I've seen about 1 in 100,000 runs that has to do with an invalid path being generated (!), but I don't think that has anything to do with my changes or tests (and there's not a muted test for it). I'll see about running it down separately.