Introduce ESTestCase.randomArrayOtherThan() methods #136707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing randomValueOtherThan() method uses Objects.equals() to determine if a randomly generated object is equal to the provided argument. This approach does not work as expected for arrays, however, since two arrays with identical contents will not be considered equal by Objects.equals(). See elastic#136652 This commit introduces randomValueOtherThanArray() methods for Object arrays and primitive arrays and converts all places in the code that were previously passing arrays into randomValueOtherThan() to use the new array-specific methods
elasticsearchmachine
added
the
needs:triage
elasticsearchmachine
removed
the
needs:triage
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Oct 16, 2025
| /** | ||
| * helper to get a random value in a certain range that's different from the input, for object arrays | ||
| */ | ||
| public static <T> T[] randomValueOtherThanArray(T[] input, Supplier<T[]> randomSupplier) { |
There was a problem hiding this comment.
Do you think it would make sense to rename this method to randomArrayOtherThan or similar to avoid the impression that the method is actually not returning array?
Maybe it's not an issue because the randomValueOtherThanMany also sounds a bit strange to me.
I'm leaving it up to you.
There was a problem hiding this comment.
I think that's a better name, yeah
DonalEvans
changed the title
elasticsearchmachine
added
the
serverless-linked
dimitris-athanasiou
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing randomValueOtherThan() method uses Objects.equals() to determine if a randomly generated object is equal to the provided argument. This approach does not work as expected for arrays, however, since two arrays with identical contents will not be considered equal by Objects.equals(). See #136652
This commit introduces randomArrayOtherThan() methods for Object arrays and primitive arrays and converts all places in the code that were previously passing arrays into randomValueOtherThan() to use the new array-specific methods