Skip to content

Fix NPE in HealthApiFeatureSetUsageTests testEqualsAndHashcode #136742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2025
Merged

Fix NPE in HealthApiFeatureSetUsageTests testEqualsAndHashcode #136742

merged 3 commits into from
Oct 17, 2025

Conversation

cbuescher
Copy link
Member

Small test fix of an NPE that could happen after a recent refactoring.

@cbuescher cbuescher added >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.3.0 labels Oct 17, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Oct 17, 2025
dimitris-athanasiou
dimitris-athanasiou reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Just left a question.

test/framework/src/main/java/org/elasticsearch/test/AbstractWireTestCase.java Outdated
* versions of the instance are equal.
*/
public final void testEqualsAndHashcode() {
public void testEqualsAndHashcode() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of final here intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, leftover from reproduction, will revert this part.

elasticsearchmachine and others added 2 commits October 17, 2025 09:03
dimitris-athanasiou
dimitris-athanasiou approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbuescher cbuescher added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Oct 17, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Oct 17, 2025
@cbuescher cbuescher added the :Search Foundations/Search Catch all for Search Foundations label Oct 17, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Oct 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 17, 2025
@cbuescher cbuescher added :Search Relevance/Highlighting How a query matched a document needs:triage Requires assignment of a team area label labels Oct 17, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed needs:triage Requires assignment of a team area label labels Oct 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@cbuescher cbuescher removed the :Search Relevance/Highlighting How a query matched a document label Oct 17, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Oct 17, 2025
@cbuescher cbuescher merged commit 0dcf3ed into elastic:main Oct 17, 2025
34 checks passed
@cbuescher cbuescher mentioned this pull request Oct 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees

No one assigned

Labels

:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbuescher @elasticsearchmachine @dimitris-athanasiou