ESQL: Rename refactored test method #136745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
I do not know the history or motivations of our naming choices but the change appears correct as described. |
alex-spies
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameterSuppliersFromTypedDataWithDefaultChecksNoErrorswithparameterSuppliersFromTypedDataWithDefaultChecks// TODOreminding thisContext
Initially, we had
parameterSuppliersFromTypedDataWithDefaultChecks()method used on function tests, automatically adding extra autogenerated cases.Then, we moved the "invalid parameter types" to another test class (For every function), deprecated that method, and added a new
parameterSuppliersFromTypedDataWithDefaultChecksNoErrors().Eventually, the migration was completed, and we removed the old method. But the new one wasn't renamed again.
This PR renames it to what it was.