Skip to content

Conversation

romseygeek
Copy link
Contributor

Updates the relevant IndexVersion so that we can re-enable the
index.mapping.use_doc_values_skipper setting for logsdb
nightly runs and see what effect it has.

Also includes changes to the filter-by-filter aggregation optimization
to allow it to inspect doc value skippers as well as points to work out
if it is worth enabling.

@romseygeek
Copy link
Contributor Author

Once this is merged, we should update the logsdb rally tracks to include the index setting index.mapping.use_doc_values_skipper=true

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@romseygeek romseygeek added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 17, 2025
@elasticsearchmachine elasticsearchmachine merged commit b5af845 into elastic:main Oct 17, 2025
34 checks passed
@romseygeek romseygeek deleted the logsdb/timestamp-skippers branch October 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :StorageEngine/Logs You know, for Logs Team:StorageEngine v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants