[ML] Update the voyageai integration #136782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fzowl
commented
Oct 19, 2025
fzowl
commented
- correcting the multimodal integration
- adding the contextual model support
- refactoring
Collaborator
|
@fzowl please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
elasticsearchmachine
added
v9.3.0
external-contributor
fzowl
changed the title
Contributor
Author
|
@davidkyle Can you please take a look? |
szybia
added
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Member
|
@elasticmachine test this please |
davidkyle
reviewed
Oct 22, 2025
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
@fzowl there has been a refactoring since the original PR #122134. All the VoyageAI related request and response classes have been moved from the org.elasticsearch.xpack.inference.external package to org.elasticsearch.xpack.inference.services.voyageai. It looks like git has recreated all the old classes in org.elasticsearch.xpack.inference.external
Please can you try to apply the changes to the classes in org.elasticsearch.xpack.inference.services.voyageai. It may be easier to close this PR and open another with the last few commits from this PR applied - e778e36 and b7351e7?
Thanks
- embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
Moving dimensions to ServiceSettings
* Fix irregular spaces * Update analysis-keyword-repeat-tokenfilter.md * Update search-suggesters.md * Update search-profile.md
- Add multimodal embeddings support with VoyageAIMultimodalEmbeddings* classes - Add contextual embeddings support with VoyageAIContextualEmbeddings* classes - Refactor text embeddings: move to embeddings/text subdirectory for better organization - Remove old embedding classes from embeddings root directory - Update action creators and visitors to handle new embedding types - Update imports in InferenceNamedWriteablesProvider - Add corresponding request/response entities for multimodal and contextual embeddings - Update unit tests for all new and modified components
- Move text embeddings test files to text/ subdirectory - Fix package declarations in test files - Update VoyageAIEmbeddingsResponseEntityTests to use correct API methods - Change .service() to .getService() and add .getConfigurations() - NOTE: Additional test import fixes needed for full compilation
- Update all VoyageAI test imports to use embeddings/text package - Fix VoyageAIMultimodalEmbeddingsTaskSettings constructor calls (add truncation param) - Fix VoyageAIMultimodalEmbeddingsServiceSettings constructor calls (add embeddingType param) - Update test files: VoyageAIServiceTests, VoyageAIActionCreatorTests, VoyageAIEmbeddingsActionTests - Update test files: VoyageAIEmbeddingsRequestTests, VoyageAIRequestTests - Update test files: VoyageAIMultimodalEmbeddingsTaskSettingsTests, VoyageAIMultimodalEmbeddingsModelTests - Update test files: VoyageAIMultimodalEmbeddingsRequestTests Remaining: 3 compilation errors to fix
- Fix VoyageAIMultimodalEmbeddingsModel constructor call in response tests - Fix VoyageAIServiceTests multimodal model creation (add taskSettings param) - Fix VoyageAIContextualEmbeddingsTaskSettings ambiguous constructor - Cast SecretSettings to DefaultSecretSettings where required
fzowl
force-pushed
the
update_the_voyageai_integration
branch
from
cbdf827 to
17e88d6
Compare
Contributor
Author
|
Closing this PR as we've cleaned up the integration in the voyageai-integration-v2 branch. Opening a new PR with the clean changes. |
1 similar comment
Contributor
Author
|
Closing this PR as we've cleaned up the integration in the voyageai-integration-v2 branch. Opening a new PR with the clean changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.