Skip to content

test(TestInferenceService): prevent negative embedding values #136806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

test(TestInferenceService): prevent negative embedding values #136806

merged 4 commits into from
Oct 21, 2025

Conversation

@mromaios
Copy link
Contributor

@mromaios mromaios commented Oct 20, 2025 •
edited
Loading

Closes #133453

This PR fixes edge cases where the generated test embeddings could become negative.

  • Math.abs can overflow when the provided int is Integer.MIX_VALUE causing a negative embedding value
  • The expression <abs(hashCode)> + 1 + position was computed as an int which can also overflow if the absolute value is close to Integer.MAX_VALUE

@mromaios mromaios self-assigned this Oct 20, 2025
@mromaios mromaios added >test Issues or PRs that are addressing/adding tests :SearchOrg/Relevance Label for the Search (solution/org) Relevance team labels Oct 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 20, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine elasticsearchmachine added Team:Search - Relevance The Search organization Search Relevance team v9.3.0 labels Oct 20, 2025
@mromaios mromaios changed the title test(ShardBulkInferenceActionFilterIT): prevent negative embedding values test(TestInferenceService): prevent negative embedding values Oct 20, 2025
@mromaios mromaios marked this pull request as draft October 20, 2025 13:52
@mromaios mromaios marked this pull request as ready for review October 20, 2025 15:37
Mikep86
Mikep86 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we also backport this as far back as 8.19? This test code has been around for a while and it's only a matter of time until get failures for those releases as well.

@mromaios mromaios added auto-backport Automatically create backport pull requests when merged v8.19.6 v9.1.6 v9.0.9 v9.2.1 labels Oct 21, 2025
@mromaios
Copy link
Contributor Author

mromaios commented Oct 21, 2025

LGTM! Can we also backport this as far back as 8.19? This test code has been around for a while and it's only a matter of time until get failures for those releases as well.

Sure, on it.

@mromaios mromaios merged commit 9d63517 into elastic:main Oct 21, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 21, 2025

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 136806

This was referenced Oct 21, 2025
Merged
Merged
mromaios added a commit to mromaios/elasticsearch that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (elasti…
0720d49 
…c#136806)

(cherry picked from commit 9d63517)
This was referenced Oct 21, 2025
Closed
Merged
@mromaios
Copy link
Contributor Author

mromaios commented Oct 21, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.2
✅ 9.1
✅ 9.0
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

mromaios added a commit to mromaios/elasticsearch that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (elasti…
39b2df8 
…c#136806)

(cherry picked from commit 9d63517)
mromaios added a commit to mromaios/elasticsearch that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (elasti…
c767c73 
…c#136806)

(cherry picked from commit 9d63517)
mromaios added a commit to mromaios/elasticsearch that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (elasti…
6d95be3 
…c#136806)

(cherry picked from commit 9d63517)
mromaios added a commit that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (#136806)…
e1d9a15 
… (#136855)

(cherry picked from commit 9d63517)
mromaios added a commit that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (#136806)…
4e896b1 
… (#136856)

(cherry picked from commit 9d63517)
mromaios added a commit that referenced this pull request Oct 21, 2025
@mromaios
test(TestInferenceService): prevent negative embedding values (#136806)…
8a157c3 
… (#136858)

(cherry picked from commit 9d63517)
@mromaios mromaios removed the v9.0.9 label Oct 21, 2025
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
@mromaios @chrisparrinello
test(TestInferenceService): prevent negative embedding values (elasti…
852d157 
…c#136806)
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Nov 3, 2025
@mromaios @fzowl
test(TestInferenceService): prevent negative embedding values (elasti…
61b9288 
…c#136806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikep86 Mikep86 Mikep86 approved these changes

Assignees

@mromaios mromaios

Labels

auto-backport Automatically create backport pull requests when merged backport pending :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team >test Issues or PRs that are addressing/adding tests v8.19.6 v9.1.6 v9.2.1 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] ShardBulkInferenceActionFilterIT testRestart {p0=false p1=true} failing

3 participants

@mromaios @elasticsearchmachine @Mikep86